search

reconciliation-api / specs

Specifications of the reconciliation API
https://reconciliation-api.github.io/specs/draft/
30 stars 9 forks source link

Remove JSONP support #142

Closed osma closed 8 months ago

osma commented 9 months ago

While I'm at it making PRs, I propose that we drop JSONP support altogether. This PR does it.

As already explained in #19, it's an obsolete an insecure mechanism for making cross-origin HTTP requests. It was already made optional for spec version 0.2, but I think it's better to leave it out from the API spec entirely because CORS is already mandated (since 0.2) and does the same thing, but in a better way.

osma commented 9 months ago

Thanks for the quick approval @wetneb! Can I just merge this or do we need to wait for opinions from others?

wetneb commented 9 months ago

It seems relatively uncontentious but let's wait for another opinion, I guess it should not have merge conflicts with other open PRs anyway.

osma commented 9 months ago

The problem with merge conflicts is caused by the list of changes included in the spec. I thought it would make sense to add a brief mention of the changes I made in the same PR that implements those changes. But that inevitably leads to merge conflicts when there are more than one open PRs making that kind of changes. Fortunately those should be easy to resolve.