Schema mixes snake and camel case?

reconciliation-api / specs

Specifications of the reconciliation API

https://reconciliation-api.github.io/specs/draft/

31 stars 9 forks source link

Schema mixes snake and camel case? #150

Closed derenrich closed 3 months ago

derenrich commented 8 months ago

Why does the API mix camel and snake case? The service manifest has keys named

identifierSpace, schemaSpace, defaultTypes
feature_view

Presumably you would want to use one or the other? Is it that you are using snake for objects and camel for values/arrays? But later in suggest metadata you use service_url to refer to a string? I'm confused.

derenrich commented 8 months ago

Also, the manifest spec mentions a key called batchSize but this is not included in the json schema at the bottom of the spec

wetneb commented 8 months ago

Thanks! I think it would be worth normalizing this in the current draft indeed.