search

reconciliation-api / specs

Specifications of the reconciliation API
https://reconciliation-api.github.io/specs/draft/
31 stars 9 forks source link

Normalize naming conventions across the API #95

Closed wetneb closed 2 months ago

wetneb commented 2 years ago

In the manifest we have fields such as identifierSpace and feature_view. We should settle on a style: either identifierSpace and featureView, or identifier_space and feature_view.

I think in JSON it is somehow more common to have feature_view than featureView.

thadguidry commented 2 years ago

Agree, underscore separation

wetneb commented 2 years ago

Yeah but on the other side, the identifierSpace and schemaSpace have been there for ages, whereas feature_view, so it would likely be much less disruptive to rename the latter…

fsteeg commented 2 months ago

Resolved with #166 (PR for #150, which was a duplicate of this), closing.