reconhub / epicontacts

Handling, Visualisation and Analysis of Epidemiological Contacts
http://www.repidemicsconsortium.org/epicontacts/
15 stars 19 forks source link

Address `devtools::check()` warning and note #133

Open jamesmbaazam opened 1 year ago

jamesmbaazam commented 1 year ago

When you run devtools::check(), you get the following warning and note that should probably be addressed:

❯ checking S3 generic/method consistency ... WARNING
  as.igraph:
    function(x, ...)
  as.igraph.epicontacts:
    function(x)
  See section ‘Generic functions and methods’ in the ‘Writing R
  Extensions’ manual.

❯ checking dependencies in R code ... NOTE
  Namespace in Imports field not imported from: ‘colorspace’
    All declared Imports should be used.

I will submit a PR to address these issues.

finlaycampbell commented 1 year ago

Thanks for picking up on this! The as.igraph.epicontacts check warning should have been addressed here (ecd721e67aacec15eb36645da9f1035ef89ae6ff), so I'm not sure why you're still seeing it...

jamesmbaazam commented 1 year ago

Strange. Is it probably a devtools bug?