Generic incidence internal constructor with stable datetime support - Githubissues

reconhub / incidence

☣:chart_with_upwards_trend::chart_with_downwards_trend:☣ Compute and visualise incidence

https://reconhub.github.io/incidence

Other

58 stars 13 forks source link

Generic incidence internal constructor with stable datetime support #43

Closed zkamvar closed 6 years ago

zkamvar commented 6 years ago

This pull request should close #42, #26, and #41

Incidence construction is no longer passed through to incidence.integer() by default. This, in part fixes #41
A separate make_breaks function has been constructed to facilitate breaks calculation for different types. This will fix #42 and #41
Support for detecting valid datetime intervals for calculating timeframe has been added to allow for binning by month to fix #26

Still needed:

[x] Printing for things like "month" or "quarter"
[x] Tests for valid datetime intervals

thibautjombart commented 6 years ago

Awesome, thanks!!