search

reconhub / incidence

☣:chart_with_upwards_trend::chart_with_downwards_trend:☣ Compute and visualise incidence
https://reconhub.github.io/incidence
Other
58 stars 13 forks source link

Fix first date error #71

Closed zkamvar closed 5 years ago

zkamvar commented 5 years ago

This will fix #70 by changing the functionality of trim_dates() to return a logical vector instead of a date vector so that both date and group vectors can be subset. Now this will also explicitly remove missing dates in this step and send a message to the user.

I've also changed the test-incidence.R file to be evaluated on CRAN and to be a bit more DRY.

I've also updated the figures and outputs

zkamvar commented 5 years ago

I assure you this works. Appveyor (as friggen usual) is failing because of stringi.

thibautjombart commented 5 years ago

I trust you :)

zkamvar commented 5 years ago

I trust you :)

Famous last words, Thibaut :wink: