Closed zkamvar closed 5 years ago
The deploy preview is at https://deploy-preview-35--reconlearn-test.netlify.com/
Thanks for this. Please address the following before merging:
[x] indentation of paragraphs is weird - see first section, either split paragraphs or merge them, but avoid carriage returns for each sentence
[x] screenshot1.png is missing
[x] screenshot2.png is missing
[x] maybe put the screenshot in a clearly named folder in static
, other than static/highres
which is meant for post pictures
[x] boxplot(cph$age)
is a bit ugly; add legends, and maybe prettify a bit?; could be good to show alternatives: hist()
; plot(density(...)
or such, coz one boxplot only is a bit underwhelming (fine to keep it in though)
[x] table(cph$case, cph$vomiting)
-> table(case = cph$case, vomit = cph$vomiting)
; check other similar instances
indentation of paragraphs is weird - see first section, either split paragraphs or merge them, but avoid carriage returns for each sentence
*cringe* ugh.... I forgot that github markdown variant actually respects carriage returns. I'll fix that.
boxplot(cph$age) is a bit ugly; add legends, and maybe prettify a bit?; could be good to show alternatives: hist(); plot(density(...) or such, coz one boxplot only is a bit underwhelming (fine to keep it in though)
Agreed. That's what was in the original practical, but it is quite a bit fugly
Also: I'm thinking of changing the panting that I have for the background image since it's by a Dutch painter when the outbreak was in a Denmark/
Ready for your approval.
Note: The copenhagen case study has been split into four practicals... all of which are linked together
Okay... It's ready now
Wikid, thanks!
DO NOT MERGE THIS PR YET
I'm in progress of adding the pieces of the practical incrementally. I will signal when all is good