reconhub / learn

RECON learn: a free, open platform for training material on epidemics analysis
https://reconlearn.org
Other
35 stars 30 forks source link

Update practical-tb.Rmd #82

Closed juanvesga closed 5 years ago

juanvesga commented 5 years ago

Now fixed tiny changes

juanvesga commented 5 years ago

Yes! My mistake

On 21 Jun 2019, at 08:47, Zhian N. Kamvar notifications@github.com<mailto:notifications@github.com> wrote:

@zkamvar commented on this pull request.


In content/post/practical-tb.Rmdhttps://github.com/reconhub/learn/pull/82#discussion_r296242684:

@@ -446,13 +446,13 @@ out0 <- get_intervention(xstart, params, NA, times, NA, NA, TB.Basic, "Initial", NA)

plot

-dot <- data.frame(Data = "Bangladesh", Years = 2017, incidence = Inc.country)

Hi @juanvesgahttps://github.com/juanvesga,

This produces an error. Was this supposed to change to country.name?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/reconhub/learn/pull/82?email_source=notifications&email_token=AD7RQFB5IRGZJEDW6OJPT5DP3TLWTA5CNFSM4H2RYPB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4I6WUI#pullrequestreview-252832593, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD7RQFHYHAGEPFXMVJNKSBLP3TLWTANCNFSM4H2RYPBQ.

juanvesga commented 5 years ago

Should I edit it again? Or can you change it?

Thanks,

Juan

On 21 Jun 2019, at 08:47, Zhian N. Kamvar notifications@github.com<mailto:notifications@github.com> wrote:

@zkamvar commented on this pull request.


In content/post/practical-tb.Rmdhttps://github.com/reconhub/learn/pull/82#discussion_r296242684:

@@ -446,13 +446,13 @@ out0 <- get_intervention(xstart, params, NA, times, NA, NA, TB.Basic, "Initial", NA)

plot

-dot <- data.frame(Data = "Bangladesh", Years = 2017, incidence = Inc.country)

Hi @juanvesgahttps://github.com/juanvesga,

This produces an error. Was this supposed to change to country.name?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/reconhub/learn/pull/82?email_source=notifications&email_token=AD7RQFB5IRGZJEDW6OJPT5DP3TLWTA5CNFSM4H2RYPB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4I6WUI#pullrequestreview-252832593, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD7RQFHYHAGEPFXMVJNKSBLP3TLWTANCNFSM4H2RYPBQ.

zkamvar commented 5 years ago

I can change it

juanvesga commented 5 years ago

Thanks!

On 21 Jun 2019, at 08:56, Zhian N. Kamvar notifications@github.com<mailto:notifications@github.com> wrote:

I can change it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/reconhub/learn/pull/82?email_source=notifications&email_token=AD7RQFBXNWD362NVVP26IVTP3TMYJA5CNFSM4H2RYPB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYIRC6I#issuecomment-504435065, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD7RQFCFDFHLPHJUUPB6HTDP3TMYJANCNFSM4H2RYPBQ.