default to guess_dates = FALSE in clean_data

reconhub / linelist

An R package to import, clean, and store case data

https://www.repidemicsconsortium.org/linelist

Other

25 stars 5 forks source link

default to guess_dates = FALSE in clean_data #102

Closed thibautjombart closed 4 years ago

thibautjombart commented 4 years ago

From what I have seen of using clean_data: as soon as the data starts having a realistic size, things become quite messy and looking for dates in all variables is a big timewaste, the common practice becoming something along the lines of:


x_clean <- x_raw %>%
    clean_data(guess_dates = FALSE) %>%
    mutate_at(contains("date"), guess_dates)

I think it would make sense to default to guess_dates = FALSE in clean_data. Will implement this change via PR.

zkamvar commented 4 years ago

Should this be closed? I think it was taken care of in #103

thibautjombart commented 4 years ago

Yep thanks