search

reconhub / report_factories_templates

Templates of report factories
8 stars 8 forks source link

review: weekly_presentation_background #13

Open thibautjombart opened 4 years ago

thibautjombart commented 4 years ago

We need a review for the weekly_presentation_background report. There is a lot of code duplicated from other reports which needs to be removed; quite possibly, keep only the text automatically generated.

Quick links to:

golden rules for writing reports: https://github.com/reconhub/guides/raw/master/golden_rules.html.zip

guide to review: https://github.com/reconhub/report_factories_templates#revewing-changes

thibautjombart commented 4 years ago

@nsbatra flagging you as a representative for HQ ;) This report has a lot that needs removing, essentially all parts that already exist somewhere else. I suspect only the automatically generated text will remain.