search

reconhub / report_factories_templates

Templates of report factories
8 stars 8 forks source link

Fix NA's when age<1 #2

Closed joewalker127 closed 5 years ago

joewalker127 commented 5 years ago

Translates age values initially from scientific notation (can occur when age < 1 year in raw excel import) to standard notation to prevent NA's from arising when calling "age = as.numeric(age)"

thibautjombart commented 5 years ago

Thanks for this. Will have a look code-wise but @jarvisc1 will handle the PR in terms of functionality. The source of the error seemed to be a 05./12 in the google shit that was missing an = sign and thus was text, so the entire variable is promoted to character when imported into R and then cleaned as such by clean_data.

jarvisc1 commented 5 years ago

Looking further into the data it looks like this was cased by some strange unicode character in the original data which convert the value to character when R reads in the data. We looking at removing the unicode character and then the scientific value is read in correctly within R. In that case there won't be any strange values with 0.23.E3 so this step won't be needed.

For the moment we'll hold off on this. Thanks for putting the PR together.

jarvisc1 commented 5 years ago

Closed as data issue is sorted.