reconhub / trendbreaker

Analysing epidemic trends using AutoML approaches.
Other
18 stars 7 forks source link

Fix issue 45 #46

Closed thibautjombart closed 3 years ago

thibautjombart commented 3 years ago

This implements the following changes to fix https://github.com/reconhub/trendbreaker/issues/45. This should be safe to use with stratified data, varied time intervals, and non-ordered data.

Passes the check on:

> R.version
               _                           
platform       x86_64-pc-linux-gnu         
arch           x86_64                      
os             linux-gnu                   
system         x86_64, linux-gnu           
status                                     
major          4                           
minor          0.3                         
year           2020                        
month          10                          
day            10                          
svn rev        79318                       
language       R                           
version.string R version 4.0.3 (2020-10-10)
nickname       Bunny-Wunnies Freak Out     
TimTaylor commented 3 years ago

Looks good to me. I've made a couple of minor additional commits. I'll let you check these first and then we can merge.