search

reconquest / atlassian-external-hooks

External Hooks plugin for Atlassian Bitbucket
https://external-hooks.reconquest.io
Other
44 stars 37 forks source link

BugFix - Column Name Case Sensitivity #124

Closed briankohler closed 2 years ago

briankohler commented 2 years ago

This fixes #125 Postgres-backed BitBucket Server installations, where column names are case sensitive. A new installation of External Hooks on a Postgres-backed BitBucket instance will throw errors on the Global Hooks admin page without this change

briankohler commented 2 years ago

I could not find any other code that interfaces with the DB outside the ORM. I compiled this change myself and it's working fine on our Bitbucket Server instance. MySQL columns are not case-sensitive, so this should have no effect on MySQL-backed Bitbucket instances. I did not increment the version, as I am unfamiliar with how that works with the marketplace, etc.

kovetskiy commented 2 years ago

Hi! Thanks for your contribution! I'm currently working on improving our integration tests to support all databases (postgres, oracle, mysql) so I'll be able to prove that your fix works fine for all databases, and then I'll merge the PR and release a new version.

Thanks!