search

reconquest / atlassian-external-hooks

External Hooks plugin for Atlassian Bitbucket
https://external-hooks.reconquest.io
Other
44 stars 37 forks source link

Merge check hook #34

Closed andreineculau closed 8 years ago

andreineculau commented 8 years ago

an alternative to #32 , fixing #18 which reuses code from the pre-receive hook, and is built for Bitbucket server

NOTE the "remove duplicate code" commit is NOT tested. It compiles, but I don't have the means to test the functionality at the moment.

greened commented 8 years ago

Do you know if this will still work with Stash 3.11? We haven't migrated yet and I don't know when that will happen.

andreineculau commented 8 years ago

I think it's obviously not from all the "import com.atlassian.bitbucket..." AFAIK two separate addon versions would be needed in order to bring this functionality to Stash 3 and Bitbucket Server 4

On Thu, Apr 21, 2016 at 8:32 PM, David Greene notifications@github.com wrote:

Do you know if this will still work with Stash 3.11? We haven't migrated yet and I don't know when that will happen.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/ngsru/atlassian-external-hooks/pull/34#issuecomment-213056127

andreineculau.com http://www.andreineculau.com

greened commented 8 years ago

I figured that would be the case but I didn't know if there's an option for conditional compilation to handle multiple API versions. I'll try to backport your code to 3.11 on another branch.

EDIT: It's not really possible to backport due to major API changes so I'll just use my original version for now since it works for us.

seletskiy commented 8 years ago

@greened, @andreineculau: I guess, we all agree, that we should merge in @andreineculau's version?

greened commented 8 years ago

Yes, merge @andreineculau's version. Thanks!

I will maintain my own fork for 3.11. If you want it I'm happy to submit it.