reconquest / atlassian-external-hooks

External Hooks plugin for Atlassian Bitbucket
https://external-hooks.reconquest.io
Other
44 stars 37 forks source link

Adding compatibility with Bitbucket Server 5.0.1 #52

Closed rubiot closed 7 years ago

rubiot commented 7 years ago

This adds compatibility with Bitbucket Server 5.0.1 addressing issue https://github.com/ngsru/atlassian-external-hooks/issues/51.

rubiot commented 7 years ago

Thanks! Will there be a new release any time soon?

seletskiy commented 7 years ago

@rubiot: Unfortunately, I can't build plugin using latest version of Atlassian SDK, probably, due to this error: https://ecosystem.atlassian.net/browse/AMPS-1312

rubiot commented 7 years ago

OK. Let's hope the ticket gets solved. But before that, I found the merge check hook still had a runtime error. I'll send a new pull request soon.

abeutel commented 7 years ago

@seletskiy I was able to build the jar using atlas-mvn release:prepare and atlas-mvn release:perform. Had to add <scm>...</scm> and <distributionManagement>...</distributionManagement> configuration to the pom.xml

seletskiy commented 7 years ago

@abeutel: Thanks for giving me hint how to build it. Can you, please, test latest version from marketplace?

Also, repository is now at https://github.com/seletskiy/atlassian-external-hooks

abeutel commented 7 years ago

@seletskiy Yes, works for me in Bitbucket Server 5.0.1 (besides the known issues with Hooks and Git >= 2.11 – e.g. https://jira.atlassian.com/browse/BSERV-9388 ). Thanks for the update!