search

reconquest / atlassian-external-hooks

External Hooks plugin for Atlassian Bitbucket
https://external-hooks.reconquest.io
Other
44 stars 37 forks source link

Update to the 5.0 APIs, and now pass in the quarantine environment variables #56

Closed itay closed 6 years ago

itay commented 7 years ago

I've updated the code to properly use the new 5.0 hook APIs, as well as pass in the environment variables. This will make it work with the newer versions of Git.

I'm not sure how to properly update the pom.xml here, so I will leave that to @seletskiy or someone else who can suggest. The plugin may need to be marked as 5.0+ only now as well, though I'm not sure.

@bturner if you're able to take a look and give feedback, that would be very welcome.

seletskiy commented 7 years ago

@itay: Please, make PR to https://github.com/seletskiy/atlassian-external-hooks, I do not have access to current repo anymore.

itay commented 7 years ago

@bturner thanks for the feedback.

@seletskiy I will correct these and open a new PR against your repo!

fncmedia commented 6 years ago

@itay I sounds like your fix could solve our current problems. Have you already a timing for finishing your pr?

seletskiy commented 6 years ago

@itay: ping.

joerg commented 6 years ago

Hi, I just stumbled upon this because our pre-recieve hooks are not working any more. Seems the missing GIT_QUARANTINE_PATH is the cause. Any chance to get this fixed?

chroto commented 6 years ago

We also are struggling with this and would like to see it merged. Anything I can help with?

chroto commented 6 years ago

@itay @seletskiy would it be in bad form to open this PR on https://github.com/seletskiy/atlassian-external-hooks myself ?

itay commented 6 years ago

Please go ahead :) No reason to block this on my unavailability!

DrVanScott commented 6 years ago

I added this PR on seletskiy's some days ago. Hope i did it the right way... https://github.com/seletskiy/atlassian-external-hooks/pull/3

seletskiy commented 6 years ago

Yep, everything is fine, I just managed to obtain ownership over repository back. I'm going to release new version soon, so stay in touch :)

On Wed, Jan 31, 2018, 17:28 DrVanScott notifications@github.com wrote:

I added this PR on seletskiy's some days ago. Hope i did it the right way... seletskiy#3 https://github.com/seletskiy/atlassian-external-hooks/pull/3

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/reconquest/atlassian-external-hooks/pull/56#issuecomment-361890099, or mute the thread https://github.com/notifications/unsubscribe-auth/AApL_N2XtnLfquhtV_1zTjalc4-2kfEVks5tQEBWgaJpZM4O73K0 .

fncmedia commented 6 years ago

@seletskiy can you make an estimate when you would update your plugin?