search

reconquest / atlassian-external-hooks

External Hooks plugin for Atlassian Bitbucket
https://external-hooks.reconquest.io
Other
44 stars 37 forks source link

Merge-Check hook not re-run without changing PR #88

Closed dramaturg closed 5 years ago

dramaturg commented 5 years ago

We want to use a merge-check depending on external state. This should be possible since merge-checks are supposed to run every time a PR is viewed:

https://github.com/reconquest/atlassian-external-hooks/wiki/Configuration

MergeCheck- hook runs every time when somebody visits a pull request page, if hook exists with non-zero exit code user will be not able to merge pull request and will see a message from external hook that served check.

However, it looks like this is no longer true. A comment in issue #75:

The plugin doesn't run merge check hook on every page visit, the plugin runs merge check hook once for every pull-request update, stores the result in the database and shows it next time when you visit pull-request's page.

And points to code that as of 998693ba7d1d1107af86c2c926dae0fad17f5688 seems to have removed this behaviour.

Is there any way to restore this mode of operation for when the state of the merge-check is outside of what's in the PR? Can this be made configurable maybe?

dramaturg commented 5 years ago

Please excuse the spam - I see such an option was already added in another release. :-)