search

recp / cglm

📽 Highly Optimized 2D / 3D Graphics Math (glm) for C
MIT License
2.34k stars 231 forks source link

wasm: replace usage of -0.f to 0x80000000 #292

Closed myfreeer closed 1 year ago

myfreeer commented 1 year ago

Part of https://github.com/recp/cglm/pull/291

Should note that only glmm_float32x4_SIGNMASK_PNPN is used in wasm simd128.

This should not change the compiled output, according to compiler explorer compiler explorer

recp commented 1 year ago

@myfreeer many thanks for fast response and for the PR. The PR is merged 🚀

myfreeer commented 1 year ago

@recp It seems you have merged this after https://github.com/recp/cglm/pull/291, this pr is targeting recp:fix-simd-signmask to be part of https://github.com/recp/cglm/pull/291, so this is not yet part of master.

recp commented 1 year ago

@myfreeer my mistake sorry, https://github.com/recp/cglm/pull/293 brings the changes to master.