search

recp / cglm

📽 Highly Optimized 2D / 3D Graphics Math (glm) for C
MIT License
2.34k stars 231 forks source link

NDEBUG #394

Closed mkohlhaas closed 8 months ago

mkohlhaas commented 9 months ago

Could you check for NDEBUG instead of only DEBUG and _DEBUG for print functions (CGLM_DEFINE_PRINTS) et al, e.g in include/cglm/io.h?

NDEBUG is only used for MSVC in CMakeLists.txt but is actually defined in the C++ standard and so used also by every C Compiler.

Best regards!

recp commented 9 months ago

Hi @mkohlhaas,

Thanks for the feedback, I've just created a PR: https://github.com/recp/cglm/pull/395

recp commented 8 months ago

The PR is merged, thanks

mkohlhaas commented 8 months ago

Wow! You're strict!