search

recp / cglm

📽 Highly Optimized 2D / 3D Graphics Math (glm) for C
MIT License
2.34k stars 231 forks source link

Struct API glms_ray_at incorrect dir param. #402

Closed nitrix closed 8 months ago

nitrix commented 8 months ago

Fixes what appears to me like an accidental copy-paste mistake with the dir parameter of the struct API for glms_ray_at(). Introduced in https://github.com/recp/cglm/commit/73a4fc76d7a91d65ab4619e20a6833b0111fd402 (v0.9.3), discovered during compilation by Clang warnings.

[build] ***/vendor/cglm/include/cglm/struct/ray.h:76:33: warning: unused parameter 'dir' [-Wunused-parameter]
[build] glms_ray_(at)(vec3s orig, vec3s dir, float t) {
[build]                                 ^
[build] 1 warning generated.
recp commented 8 months ago

Hi @nitrix,

Thanks for the catch and your contributions, the PR is merged 🚀