aabb2d Struct API missing diag and sizev functions from Array API

recp / cglm

📽 Highly Optimized 2D / 3D Graphics Math (glm) for C

MIT License

2.26k stars 229 forks source link

aabb2d Struct API missing diag and sizev functions from Array API #429

Open rogeriodomingos opened 3 weeks ago

rogeriodomingos commented 3 weeks ago

The aabb2d Struct API has glms_aabb2d_size which should probably be renamed to glms_aabb2d_diag and call glm_aabb2d_diag from the Array API. It is also missing glms_aabb2d_sizev which should call glm_aabb2d_sizev.

recp commented 3 weeks ago

Hi @rogeriodomingos,

Thanks for the catch! I’ll do it asap if no one intends to create a PR :)

duarm commented 1 week ago

I might pick this one up this weekend, it's my fault anyway

recp commented 1 week ago

Hi @duarm,

Sounds great, thanks! 👍