search

recruit-mp / RMPZoomTransitionAnimator

A custom zooming transition animation for UIViewController
MIT License
1.71k stars 178 forks source link

[Enhancement] Callback on animation completions #4

Closed jfradj closed 9 years ago

jfradj commented 9 years ago

Hello,

It would be great to have two optionals methods in RMPZoomTransitionAnimating protocol to be notified of the end of the forward and backward animations.

Great work by the way.

Cheers

jfradj commented 9 years ago

Or even better, the RMPZoomTransitionAnimating protocol could require a new method to get the original UIImageView (the source of the image view returned by -(UIImageView *)transitionSourceImageView; ) and hide it, while the copy is being animated. And when the animation is done, the original could be shown.

That will prevent the original views to be shown while animating.

Hope it's clear.

mpon commented 9 years ago

Thanks for the feedback @jfradj. I think this will need some improvement. I deal with something lightly and temporarily in RMPZoomTransitionAnimator.m#L59-L62 to add the alpha view. So, i will try your suggestion, and hope your pull request!

mpon commented 9 years ago

fix #6