search

recruit-mp / RMPZoomTransitionAnimator

A custom zooming transition animation for UIViewController
MIT License
1.71k stars 178 forks source link

Add animation completion handler #6

Closed m1entus closed 9 years ago

mpon commented 9 years ago

Hi @m1entus, Thanks for your PR. I think this will fix #4, so I will merge this :+1:

But I want to know your idea, why did you separete theRMPZoomTransitionAnimating protocol and the RMPZoomTransitionDelegate protocol? I think it is not necessary to separate protocol.

@jfradj This PR will fix your issue #4?

m1entus commented 9 years ago

The main reason is that it serves a completely different function, it is callback for some kind of functionality, not a interface(protocol) that must implement some kind functionality for viewController to be "Transitioning".  If future as a delegate handler could be different object that viewController which implements transitioning protocol. If you think that is not necessary feel fre to refactor it to one protocol.

mpon commented 9 years ago

@m1entus I get it. Thank your for your help. :relieved: