recsyschallenge / 2017

40 stars 24 forks source link

success() function not defined in evaluation #18

Closed manoj1992 closed 7 years ago

manoj1992 commented 7 years ago

Hi,

In the itemSuccess() function, I believe the success(item, u) method is not defined, or maybe I am not understanding it correctly. Does it mean that the user u positively interacted (click or bookmark) with the item? Thanks.

fabianabel commented 7 years ago

Thank you for spotting this. It should be userSuccess not success: if (users.filter(u => userSuccess(item, u) > 0).size > 1)... We changed it. Thank you, fabian