recsyschallenge / 2017

40 stars 24 forks source link

Question about evaluation metric #21

Closed mattiadagrada closed 7 years ago

mattiadagrada commented 7 years ago

I found out something that looks like an inconsistency between your description of the evaluation metric and your pseudocode:

Which one should we consider correct? Thanks in advance

fabianabel commented 7 years ago

Thank you for spotting this! It should be: ...userSuccess(item, u) > 0) not ...success(item, u). Anyways, the pseudo code and textual description should mean the same thing: users.filter(u => userSuccess(item, u) > 0) (Scala-like pseudo code) should give you those users for whom we observe a successful push recommendation (for the given item) - where successful means: userSuccess(item, u) > 0.

mattiadagrada commented 7 years ago

Yeah but my question was more about the :

if (users.filter(u => userSuccess(item, u) > 0) .size > 1)

while in the description you say :

if at least ONE successful push recommendation

Is that supposed to be size > 0 or am I missing something here? thanks

fabianabel commented 7 years ago

Yes, correct. Changed it correspondingly. Thank you, fabian