search

recsyschallenge / 2017

40 stars 24 forks source link

baseline details about file "xgb.py" #23

Closed phsimon closed 7 years ago

phsimon commented 7 years ago

Hi,

In this file, in github, in line 57, one can read "param['nthread'] = 4" and in line 59 "param['nthread'] = 5". Is it OK ?

Another question, the comment says, max depth for the tree 6, but in line 56, one can read "'bst:max_depth': 2" ?

Best regards.

dkohlsdorf commented 7 years ago

Good catch the actual value of the depth is correct ... I forgot to adjust the comment. With the threads I forgot to delete the first param. But the script is running ok. However, the cleanup is commited.

Daniel