search

rectorphp / getrector-com

Rector Website
https://getrector.com
MIT License
25 stars 37 forks source link

Potential improvement to docs #2547

Closed u01jmg3 closed 1 week ago

u01jmg3 commented 2 weeks ago

I noticed in the documentation for withPhpSets() it mentions targeting PHP 7.3 yet the code example uses named arguments that weren't introduced until PHP 8.0.

php-sets

My suggestion would be to include an example using withSets() just like is mentioned elsewhere in the docs:

first-run

e.g.

-    ->withPhpSets(php73: true)
+    ->withSets([SetList::PHP_73])

Happy to contribute this change but I don't know which repo Rector docs are saved to.

TomasVotruba commented 2 weeks ago

Thanks for proposal :+1:

Could you send a PR to improve this?