search

rectorphp / rector-book-feedback

[BOOK] Repository for feedback from readers of Rector book, to improve it continuously
https://leanpub.com/rector-the-power-of-automated-refactoring
15 stars 2 forks source link

Skipping Single-script fixtures? #47

Closed marcitqualab closed 10 months ago

marcitqualab commented 2 years ago

Text Improvement

I think the text on page 93 could be improved:

"Fixtures that contain only a single script are examples of code that your rule should “skip”, so the Rector project itself uses the convention to start these fixtures with skip- as well."

Why?

Because it is hard to understand, it isn't very clear.

I am not able to understand properly this text to provide a proposal. My question is. If the fixture has the example code to be tested against the rule and this fixture is skipped (so not runner against de rule) then the test is always going to pass as the rule will not be executed and the fixture will always be the same? I think I am missing something here and the definition of the key point above does explain well this point.

Thanks!

matthiasnoback commented 2 years ago

Thanks for providing this feedback, we'll make sure to process this in the next update of the book!

TomasVotruba commented 10 months ago

Thanks, I understand it sound like "skip test" and could be confusing.

l'll integrate this suggestion to next wek book release for Rector 0.19.

Thank you :+1: