rectorphp / rector-doctrine

Rector upgrade rules for Doctrine
https://getrector.com/find-rule?activeRectorSetGroup=doctrine
MIT License
58 stars 55 forks source link

Annotation to Attribute didn't if class has different case #301

Closed oleg-andreyev closed 8 months ago

oleg-andreyev commented 8 months ago

Running rector noticed that annotation is not removed, it looks like because it's misspelled by case.

image

As soon as I've changed to InheritanceType, rector replaced

samsonasik commented 8 months ago

I think that edge case that you need to clear yourself, as annotation can be class name or generic text, eg: @required, checking @ReQUIred probably not what it should be

oleg-andreyev commented 8 months ago

Right. It's that case, but PHP itself is case insensitive with class-names.

samsonasik commented 8 months ago

changing annotation to attribute doesn't verify if class exists, verify only same value changed, if any different case, that should be cleaned by hand.