search

rectorphp / rector-phpunit

Rector upgrade rules for PHPUnit
http://getrector.com
MIT License
62 stars 47 forks source link

Rename class fixture #196

Closed samsonasik closed 1 year ago

samsonasik commented 1 year ago

Avoid random error test like in https://github.com/rectorphp/rector-src/actions/runs/5344729318/jobs/9689468923?pr=4315#step:7:26

samsonasik commented 1 year ago

The original test itself is invalid, need to be fixed:

     /**
      * @dataProvider provideDataSomething()
      */
+    /**
+     * @dataProvider provideDataSomething()
+     */
samsonasik commented 1 year ago

Fixed 🎉

samsonasik commented 1 year ago

This is really strange, local and CI is different

samsonasik commented 1 year ago

@TomasVotruba fixed ;), this also fix the mirror comment before yield ;)

TomasVotruba commented 1 year ago

Thanks for the fix ;)