Fix/272 Strict phpunit10 feature for php 81

rectorphp / rector-phpunit

Rector upgrade rules for PHPUnit

https://getrector.com/find-rule?activeRectorSetGroup=phpunit

MIT License

64 stars 47 forks source link

Fix/272 Strict phpunit10 feature for php 81 #289

Closed eerison closed 11 months ago

eerison commented 11 months ago

DataProviderAnnotationToAttributeRector.php and WithConsecutiveRector.php just work for phpunit10, But as there isn't the possibility to strict rules by phpunit version, then I am changing for the minimum version supported for phpunit10 (php 8.1)

Close #272

TomasVotruba commented 11 months ago

Hi, thanks for the update, this makes sense :+1:

Could you add a comment to the verison constant in the rule explaining "why"? To avoid future accidental removal.

TomasVotruba commented 11 months ago

Thank you :clap: