search

rectorphp / rector-phpunit

Rector upgrade rules for PHPUnit
http://getrector.com
MIT License
61 stars 46 forks source link

setMethods call has been removed in PHPUnit 10 #293

Closed bbrala closed 8 months ago

bbrala commented 8 months ago

Deprecated in PPHPUnit 8.3 see: https://github.com/sebastianbergmann/phpunit/commit/d618fa3fda437421264dcfa1413a474f306f79c4

Fixes #292

TomasVotruba commented 8 months ago

Thank you :clap:

samsonasik commented 8 months ago

@bbrala @TomasVotruba it seems the namespace need to be moved as well to avoid notice on rector-src:

bin/rector missing-in-set --ansi

We could not find there rules in configs
========================================

 * vendor/rector/rector-phpunit/config/sets/phpunit-code-quality.php

 * Rector\PHPUnit\CodeQuality\Rector\MethodCall\RemoveSetMethodsMethodCallRector

see https://github.com/rectorphp/rector-src/actions/runs/6828589747/job/18573042345?pr=5239#step:5:15

I temporary register to skipped rules to check on MissingInSetCommand

https://github.com/rectorphp/rector-src/pull/5239/commits/6b4ca2190ea465015ca3dfd064715e7e020247d2

bbrala commented 8 months ago

Oh you are right.

Made a PR with the fix: https://github.com/rectorphp/rector-phpunit/pull/294