search

rectorphp / rector-phpunit

Rector upgrade rules for PHPUnit
http://getrector.com
MIT License
61 stars 46 forks source link

Remove `codeCoverageIgnore` to annotation to attribute conversion #304

Closed martinssipenko closed 6 months ago

martinssipenko commented 6 months ago

As described in https://github.com/sebastianbergmann/phpunit/issues/5235 and https://github.com/sebastianbergmann/phpunit/issues/5513 the CodeCoverageIgnore attribute was a mistake and is now deprecated, therefore Rector should not try to replace annotation with the attribute.

Fixes #303

samsonasik commented 6 months ago

@martinssipenko could you update workflow file to require php 8.2 as it require rector-src? Thank you

samsonasik commented 6 months ago

@martinssipenko latest main already use php 8.2, could you rebase?

martinssipenko commented 6 months ago

@samsonasik @TomasVotruba updated

TomasVotruba commented 6 months ago

Awesome, thank you :+1: