search

rectorphp / rector-phpunit

Rector upgrade rules for PHPUnit
http://getrector.com
MIT License
61 stars 46 forks source link

Reimplement WithConsecutiveRector (#311) #313

Closed f-albert closed 2 months ago

f-albert commented 4 months ago

311 I tried to reimplement WithConsecutiveRector because the previous implementation is incorrect.

I think i need to refactor the code. It's my first time using phpparser and contributing on github. I am open to suggestions for improvements. :)

samsonasik commented 4 months ago

could you run:

vendor/bin/rector && composer fix-cs

to make CI green? Thank you.

TomasVotruba commented 4 months ago

Thanks for the proposal. It's quite difficult to review the match to switch change. We actully promote newer PHP and PHPUnit 10 is already on PHP 8+, so match is a valid option.

Could you keep the match and only change the rest? That way I'll see, what you're trying to change and why.

Thanks

f-albert commented 3 months ago

@TomasVotruba When can I expect a review?

TomasVotruba commented 2 months ago

Thanks for reviews @samsonasik :+1:

Let's give this a go :clap: