search

rectorphp / rector-phpunit

Rector upgrade rules for PHPUnit
http://getrector.com
MIT License
61 stars 46 forks source link

PreferPHPUnitSelfCallRector: Cheap checks first #316

Closed staabm closed 4 months ago

staabm commented 4 months ago

@samsonasik any feedack? failling builds looks unrelated.

TomasVotruba commented 4 months ago

It's related, the coding standard is reported:

Screenshot from 2024-03-08 14-43-20

staabm commented 4 months ago

ohh I see. the useful messages are hidden behind this error wall

grafik

samsonasik commented 4 months ago

@staabm I recall we discussed about it in old PR, not sure about clear algorithm steps vs performance.

I will let @TomasVotruba decide ;)

TomasVotruba commented 4 months ago

LGTM, let's ship it :+1: Thanks