search

rectorphp / rector-phpunit

Rector upgrade rules for PHPUnit
https://getrector.com/find-rule?activeRectorSetGroup=phpunit
MIT License
64 stars 47 forks source link

Reuse composer's script for `class-leak` rather than duplicate command line on GH action #323

Closed maks-rafalko closed 5 months ago

maks-rafalko commented 5 months ago

This is a follow up for https://github.com/rectorphp/rector-phpunit/pull/320 and related to https://github.com/rectorphp/rector-phpunit/pull/319#issuecomment-2035137884

Instead of duplicating command line on code_analysis.yaml action file, we can just reuse composer class-leak from composer.json.

Each time composer class-leak is updated, it will be automatically used on GH Action, so no need to update duplicated command twice.

Without it, we will have an issue when we start addign --skip-type for vendor/bin/class-leak in code_analysis.yaml. The same --skip-type would be added to 2 places without this PR.

TomasVotruba commented 5 months ago

Makes perfect sense :+1: Thank you