rectorphp / rector-phpunit

Rector upgrade rules for PHPUnit
http://getrector.com
MIT License
61 stars 46 forks source link

[PHPUnit 10] Fix typo assertObjectHasNotProperty -> assertObjectNotHasProperty #340

Closed samsonasik closed 2 weeks ago

samsonasik commented 2 weeks ago

Ref https://github.com/rectorphp/rector-phpunit/pull/338#pullrequestreview-2133908428

Before

There was 1 error:

1) CodeIgniter\Config\BaseConfigTest::testEnvironmentOverrides
Error: Call to undefined method CodeIgniter\Config\BaseConfigTest::assertObjectHasNotProperty()

/Users/samsonasik/www/CodeIgniter4/tests/system/Config/BaseConfigTest.php:134

After

➜  CodeIgniter4 git:(develop) ✗ vendor/bin/phpunit tests/system/Config/BaseConfigTest.php
PHPUnit 10.5.24 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.4 with PCOV 1.0.11
Configuration: /Users/samsonasik/www/CodeIgniter4/phpunit.xml.dist

..................                                           18 / 18 (100%)

Time: 00:00.317, Memory: 14.00 MB

OK (18 tests, 48 assertions)

Generating code coverage report in Clover XML format ... done [00:00.188]

Generating code coverage report in HTML format ... done [00:00.755]

Ref https://github.com/sebastianbergmann/phpunit/blob/bb24b2746512bc8be5122bb220064df8f8687451/src/Framework/Assert.php#L1052C34-L1052C60

samsonasik commented 2 weeks ago

All checks have passed 🎉 @TomasVotruba I am merging it ;)

TomasVotruba commented 2 weeks ago

Thanks :)