search

rectorphp / rector-symfony

Rector upgrade rules for Symfony
https://getrector.com/find-rule?activeRectorSetGroup=symfony
MIT License
185 stars 89 forks source link

[Configs] Fix collect routes from Symfony router on AddRouteAnnotationRector #577

Closed samsonasik closed 9 months ago

samsonasik commented 9 months ago

Fixes https://github.com/rectorphp/rector/issues/8385 Fixes https://github.com/rectorphp/rector-symfony/issues/554

samsonasik commented 9 months ago

Fixed 🎉 /cc @fpetrovic , @TomasVotruba the php token notice seems a php-doc-parser bug, unrelated to this:

1 test triggered 4 PHP warnings:

1) /home/runner/work/rector-symfony/rector-symfony/vendor/phpstan/phpdoc-parser/src/Parser/TokenIterator.php:132
Undefined array key 40

Triggered by:

* Rector\Symfony\Tests\Configs\Rector\ClassMethod\AddRouteAnnotationRector\AddRouteAnnotationRectorTest::test#4
  /home/runner/work/rector-symfony/rector-symfony/rules-tests/Configs/Rector/ClassMethod/AddRouteAnnotationRector/AddRouteAnnotationRectorTest.php:14

re https://github.com/rectorphp/rector-symfony/actions/runs/7613166670/job/20732426711?pr=577#step:5:27

samsonasik commented 9 months ago

All checks have passed 🎉 @TomasVotruba I am merging it ;)