search

rectorphp / rector-symfony

Rector upgrade rules for Symfony
http://getrector.com
MIT License
180 stars 86 forks source link

[SwiftMailer] Skip not instanceof Swift_Message on Swift_Message to email converter #605

Closed samsonasik closed 3 months ago

samsonasik commented 3 months ago

Closes https://github.com/rectorphp/rector-symfony/pull/604

samsonasik commented 3 months ago

@stefantalen I also rename underscored rule name to non-underscored for consistency

stefantalen commented 3 months ago

The same happens with other methods:

$mailing = new Mailing();
- $mailing->setSubject($request->request->get('mailing_subject'));
+  $mailing->subject($request->request->get('mailing_subject'));
samsonasik commented 3 months ago

@stefantalen I added test case and more stubs for that as needed to check the object type.

samsonasik commented 3 months ago

All checks have passed 🎉 @TomasVotruba I am merging it ;)

stefantalen commented 3 months ago

Nice work 🥳