search

rectorphp / rector-symfony

Rector upgrade rules for Symfony
http://getrector.com
MIT License
179 stars 86 forks source link

[CodeQuality] Remove no returns check on ResponseReturnTypeControllerActionRector #652

Closed samsonasik closed 1 month ago

samsonasik commented 1 month ago

Ref https://github.com/rectorphp/rector-symfony/pull/651#pullrequestreview-2207209590

the check already verified in above check:

if (! $this->returnAnalyzer->hasOnlyReturnWithExpr($classMethod, $returns))

The fixture for it already exists at

https://github.com/rectorphp/rector-symfony/blob/fcaedb34ce67a75db9ad18ed61c79de350837a58/rules-tests/CodeQuality/Rector/ClassMethod/ResponseReturnTypeControllerActionRector/Fixture/skip_no_return.php.inc#L10-L13

samsonasik commented 1 month ago

All checks have passed 🎉 @TomasVotruba I am merging it ;)