Consider widen Composer's constraints for PHPStan

rectorphp / rector

Instant Upgrades and Automated Refactoring of any PHP 5.3+ code

https://getrector.com

MIT License

8.59k stars 680 forks source link

Consider widen Composer's constraints for PHPStan #1515

Closed Aerendir closed 5 years ago

Aerendir commented 5 years ago

Currently PHPStan is constrained at version 0.11.6 but the latest patch version is 0.11.8.

This causes me to not be able to update to the latest patched version.

Is it possible to use a constraint like phpstan:~0.11.6? Or may this cause a BC that may require more deep refactorings in Rector (so, too much work for the moment and not as easy as changing the version constraint).

For reference: Tilde version range

TomasVotruba commented 5 years ago

In past (around 2-5 months ago) it caused BC break issues, PHPStan was change a lot. But maybe now it's more stable.

So we can give it a try, Travis is already testing the lowest deps: https://github.com/rectorphp/rector/blob/a69d08bac5c5ee5b6ed12b7dd8d5950f4aff42bc/.travis.yml#L9

Try PR and let's see if tests pass

Aerendir commented 5 years ago

Ok, I'll do it ASAP... Currently I'm applying Rector to an existing app...

TomasVotruba commented 5 years ago

Closing as answered, feel free to send PR when ready