search

rectorphp / rector

Instant Upgrades and Automated Refactoring of any PHP 5.3+ code
https://getrector.com
MIT License
8.47k stars 674 forks source link

Incorrect behavior of AnnotationToAttributeRector #6489

Closed stephanvierkant closed 3 years ago

stephanvierkant commented 3 years ago

Bug Report

Subject Details
Rector version last dev-master
Installed as composer dependency

Minimal PHP Code Causing Issue

See https://getrector.org/demo/84e2d162-bd1a-4fdc-98b0-17c4ffa00496

<?php

final class DemoFile
{
    /**
    * @ApiPlatform\Core\Annotation\ApiFilter(SearchFilter::class)
    */
    public string $foo;
}

Responsible rules

Expected Behavior

The argument(s) should not be removed.

samsonasik commented 3 years ago

It seems already fixed. Please try latest 0.11.20.

stephanvierkant commented 3 years ago

Thanks! Can't test it in my project because of #6495, but thanks for fixing this one! :)