Incorrect behavior of StringClassNameToClassConstantRector

[cafferata]

Bug Report

Subject	Details
Rector version	0.13.5
Rector rule	Rector\Php55\Rector\String_\StringClassNameToClassConstantRector

Rector replace the string Mandrill with the class constant.

Minimal PHP Code Causing Issue

Composer package mandrill/mandrill is included.

composer require mandrill/mandrill

Before

<?php

final class ContactMethodeType
{
    public function buildForm(): array
    {
        return [
            'Mandrill' => 'mandrill',
        ];
    }
}

After

<?php

final class ContactMethodeType
{
    public function buildForm(): array
    {
        return [
-            'Mandrill' => 'mandrill',
+            \Mandrill::class => 'mandrill',
        ];
    }
}

Class Mandrill

```php "Mandrill_ValidationError", "Invalid_Key" => "Mandrill_Invalid_Key", "PaymentRequired" => "Mandrill_PaymentRequired", "Unknown_Subaccount" => "Mandrill_Unknown_Subaccount", "Unknown_Template" => "Mandrill_Unknown_Template", "ServiceUnavailable" => "Mandrill_ServiceUnavailable", "Unknown_Message" => "Mandrill_Unknown_Message", "Invalid_Tag_Name" => "Mandrill_Invalid_Tag_Name", "Invalid_Reject" => "Mandrill_Invalid_Reject", "Unknown_Sender" => "Mandrill_Unknown_Sender", "Unknown_Url" => "Mandrill_Unknown_Url", "Unknown_TrackingDomain" => "Mandrill_Unknown_TrackingDomain", "Invalid_Template" => "Mandrill_Invalid_Template", "Unknown_Webhook" => "Mandrill_Unknown_Webhook", "Unknown_InboundDomain" => "Mandrill_Unknown_InboundDomain", "Unknown_InboundRoute" => "Mandrill_Unknown_InboundRoute", "Unknown_Export" => "Mandrill_Unknown_Export", "IP_ProvisionLimit" => "Mandrill_IP_ProvisionLimit", "Unknown_Pool" => "Mandrill_Unknown_Pool", "NoSendingHistory" => "Mandrill_NoSendingHistory", "PoorReputation" => "Mandrill_PoorReputation", "Unknown_IP" => "Mandrill_Unknown_IP", "Invalid_EmptyDefaultPool" => "Mandrill_Invalid_EmptyDefaultPool", "Invalid_DeleteDefaultPool" => "Mandrill_Invalid_DeleteDefaultPool", "Invalid_DeleteNonEmptyPool" => "Mandrill_Invalid_DeleteNonEmptyPool", "Invalid_CustomDNS" => "Mandrill_Invalid_CustomDNS", "Invalid_CustomDNSPending" => "Mandrill_Invalid_CustomDNSPending", "Metadata_FieldLimit" => "Mandrill_Metadata_FieldLimit", "Unknown_MetadataField" => "Mandrill_Unknown_MetadataField" ); public function __construct($apikey=null) { if(!$apikey) $apikey = getenv('MANDRILL_APIKEY'); if(!$apikey) $apikey = $this->readConfigs(); if(!$apikey) throw new Mandrill_Error('You must provide a Mandrill API key'); $this->apikey = $apikey; $this->ch = curl_init(); curl_setopt($this->ch, CURLOPT_USERAGENT, 'Mandrill-PHP/1.0.55'); curl_setopt($this->ch, CURLOPT_POST, true); curl_setopt($this->ch, CURLOPT_FOLLOWLOCATION, true); curl_setopt($this->ch, CURLOPT_HEADER, false); curl_setopt($this->ch, CURLOPT_RETURNTRANSFER, true); curl_setopt($this->ch, CURLOPT_CONNECTTIMEOUT, 30); curl_setopt($this->ch, CURLOPT_TIMEOUT, 600); $this->root = rtrim($this->root, '/') . '/'; $this->templates = new Mandrill_Templates($this); $this->exports = new Mandrill_Exports($this); $this->users = new Mandrill_Users($this); $this->rejects = new Mandrill_Rejects($this); $this->inbound = new Mandrill_Inbound($this); $this->tags = new Mandrill_Tags($this); $this->messages = new Mandrill_Messages($this); $this->whitelists = new Mandrill_Whitelists($this); $this->ips = new Mandrill_Ips($this); $this->internal = new Mandrill_Internal($this); $this->subaccounts = new Mandrill_Subaccounts($this); $this->urls = new Mandrill_Urls($this); $this->webhooks = new Mandrill_Webhooks($this); $this->senders = new Mandrill_Senders($this); $this->metadata = new Mandrill_Metadata($this); } public function __destruct() { curl_close($this->ch); } public function call($url, $params) { $params['key'] = $this->apikey; $params = json_encode($params); $ch = $this->ch; curl_setopt($ch, CURLOPT_URL, $this->root . $url . '.json'); curl_setopt($ch, CURLOPT_HTTPHEADER, array('Content-Type: application/json')); curl_setopt($ch, CURLOPT_POSTFIELDS, $params); curl_setopt($ch, CURLOPT_VERBOSE, $this->debug); $start = microtime(true); $this->log('Call to ' . $this->root . $url . '.json: ' . $params); if($this->debug) { $curl_buffer = fopen('php://memory', 'w+'); curl_setopt($ch, CURLOPT_STDERR, $curl_buffer); } $response_body = curl_exec($ch); $info = curl_getinfo($ch); $time = microtime(true) - $start; if($this->debug) { rewind($curl_buffer); $this->log(stream_get_contents($curl_buffer)); fclose($curl_buffer); } $this->log('Completed in ' . number_format($time * 1000, 2) . 'ms'); $this->log('Got response: ' . $response_body); if(curl_error($ch)) { throw new Mandrill_HttpError("API call to $url failed: " . curl_error($ch)); } $result = json_decode($response_body, true); if($result === null) throw new Mandrill_Error('We were unable to decode the JSON response from the Mandrill API: ' . $response_body); if(floor($info['http_code'] / 100) >= 4) { throw $this->castError($result); } return $result; } public function readConfigs() { $paths = array('~/.mandrill.key', '/etc/mandrill.key'); foreach($paths as $path) { if(file_exists($path)) { $apikey = trim(file_get_contents($path)); if($apikey) return $apikey; } } return false; } public function castError($result) { if($result['status'] !== 'error' || !$result['name']) throw new Mandrill_Error('We received an unexpected error: ' . json_encode($result)); $class = (isset(self::$error_map[$result['name']])) ? self::$error_map[$result['name']] : 'Mandrill_Error'; return new $class($result['message'], $result['code']); } public function log($msg) { if($this->debug) error_log($msg); } } ```

https://bitbucket.org/mailchimp/mandrill-api-php/src/master/src/Mandrill.php

Expected Behaviour

Rector should do nothing with the string Mandrill.

[samsonasik]

You can skip with something like this:

   $rectorConfig->ruleWithConfiguration(StringClassNameToClassConstantRector::class, [
        'Mandril'
    ]);

[TomasVotruba]

As @samsonasik , the name is similar to an existing class. Ideally the classes should be nested at least one namespace to avoid it. But some package still lask PSR-4 standard. There is no other way to separate class name from string that looks exactly like the class name.