search

rectorphp / rector

Instant Upgrades and Automated Refactoring of any PHP 5.3+ code
https://getrector.com
MIT License
8.63k stars 680 forks source link

Is rector-prefixed still maintained? #801

Closed soullivaneuh closed 5 years ago

soullivaneuh commented 5 years ago

It is indicated that release are automatic. But I see only one release and the master branch is way later than this one.

BTW, why asking to install the prefixed with dev-master version?

soullivaneuh commented 5 years ago

I tried using composer bin to install rector, but I still have weird issues like this:

vendor/bin/rector process src src-dev tests --level php70 -vvv

Fatal error: Declaration of Rector\Php\Rector\FunctionLike\ExceptionHandlerTypehintRector::refactor(Rector\Php\Rector\FunctionLike\Node $node): ?Rector\Php\Rector\FunctionLike\Node must be compatible with Rector\Contract\Rector\PhpRectorInterface::refactor(PhpParser\Node $node): ?PhpParser\Node in /code/vendor-bin/rector/vendor/rector/rector/packages/Php/src/Rector/FunctionLike/ExceptionHandlerTypehintRector.php on line 72
TomasVotruba commented 5 years ago

It actually needs a maintainer who uses it and is able to fix that. I'm not able to, since I don't use it.

I tried using composer bin to install rector, but I still have weird issues like this:

That's not recomended. The only working solution can be Rector build with: https://github.com/rectorphp/prefixer

It needs fixes by someone who use it though.

soullivaneuh commented 5 years ago

Did you give a try to https://github.com/humbug/php-scoper ?

This allow you to provide a .phar with always auto-prefix without more maintenance.

See also https://github.com/sebastianbergmann/phpunit/issues/2015

TomasVotruba commented 5 years ago

Have you checked the link I sent? :)

https://github.com/rectorphp/prefixer/blob/90e7e14ceef6763c062286f359817c985a1e2812/composer.json#L10

soullivaneuh commented 5 years ago

I didn't, booh one me. :-(

TomasVotruba commented 5 years ago

Anyway, if you'd like to help with that, I'd prepare a README with what I know and how the build should work.

soullivaneuh commented 5 years ago

I have to find some free-time. But in anyway, the documentation would be welcome for me or anyone else. :wink:

TomasVotruba commented 5 years ago

Of course, it would just increase motivation knowing it will be used right away :smile:

TomasVotruba commented 5 years ago

Closing as answered

TomasVotruba commented 4 years ago

We have working version now :+1:

See https://github.com/rectorphp/rector-prefixed