StaticCallOnNonStaticToInstanceCallRector: fixes valid static calls

[jkuchar]

Rector\Php\Rector\StaticCall\StaticCallOnNonStaticToInstanceCallRector is broken.

dibi::setConnection() which is valid static call. And it is fixed to

which is not valid anymore - as setConnection is static method. There is probably something wrong with detection of which method is static and which is not.

[TomasVotruba]

Could you send me link to dibi class on Github? The exact version you're using in your code.

If it's forked class, please provide minimal content to replicate

[jkuchar]

I use forked version of dibi, but both changes are already merged in master.

• https://github.com/dg/dibi/commit/2b5683d0f205f7db90d6e2ccf8641731147f2daf
• https://github.com/dg/dibi/commit/76593b7da460c42ca0595bed19b8ee418513e28a

[TomasVotruba]

The static annotation is already covered: https://github.com/rectorphp/rector/commit/bf3c583cc2b57cb51694ea1a537211a6b0141979

Could you add test fixture with your dibi class with setConnection() format causing this error?

After that the incorrect spot would be clear.

[TomasVotruba]

I think it's due to missing annotation, that were not in your required code yet.

Closed as covered by test. If the bug still occurs, please send new PR with test to prove that.