search

rectorphp / type-perfect

Next level type declaration check PHPStan rules
https://getrector.com/blog/introducing-type-perfect-for-extra-safety
MIT License
74 stars 4 forks source link

Consider config for NarrowReturnObjectTypeRule #13

Closed mitelg closed 3 months ago

mitelg commented 3 months ago

See #12

mitelg commented 3 months ago

as a run of the code style fixer fixed some unrelated files, I would assume, that https://github.com/rectorphp/type-perfect/blob/main/.github/workflows/code_analysis.yaml#L29 is not set up correctly :thinking: should this be run: composer check-cs --ansi instead?

mitelg commented 3 months ago

I adjusted the job, because it should have failed for example on this run https://github.com/rectorphp/type-perfect/actions/runs/9547786462/job/26313537179

samsonasik commented 3 months ago

Thank you @mitelg