search

rectorphp / type-perfect

Next level type declaration check PHPStan rules
https://getrector.com/blog/introducing-type-perfect-for-extra-safety
MIT License
76 stars 6 forks source link

[Rules] Skip enum on NarrowPublicClassMethodParamTypeRule #19

Closed samsonasik closed 5 months ago

samsonasik commented 5 months ago

Fixes https://github.com/rectorphp/type-perfect/issues/8

samsonasik commented 5 months ago

@janedbal I can't reproduce issue https://github.com/rectorphp/type-perfect/issues/8 by this test, could you verify if something missing in the test? Thank you.

janedbal commented 5 months ago

I dont see that call SkipEnum->skip(PickReasonEnum::BarcodeIssue) in there.

samsonasik commented 5 months ago

I tried and seems still working, could you create a failing test case PR? Thank you.

janedbal commented 5 months ago

Sorry, I dont think I'll spend more time with this package as I didnt find it useful for us. I just reported invalid stuff I saw in the output. If you feel I mis-reported, feel free to close this. But this one occurred multiple times.

samsonasik commented 5 months ago

Ok, I am closing it as I can't reproduce it, feel free to create a failing test case PR when you have time ;)

samsonasik commented 5 months ago

I see, I should add test to NarrowPublicClassMethodParamTypeRule

samsonasik commented 5 months ago

updated test https://github.com/rectorphp/type-perfect/pull/19/commits/d88d2892c83685a33e07dc4ed87e677a19da542c

samsonasik commented 5 months ago

Fixed 🎉

samsonasik commented 5 months ago

All checks have passed 🎉 @TomasVotruba I am merging it ;)