search

recurly / recurly-js

Simple subscription billing in the browser
https://js.recurly.com/
MIT License
646 stars 139 forks source link

Recurly-JS is no longer updating the DefinitelyTyped repo #875

Closed devinsimmons closed 2 months ago

devinsimmons commented 6 months ago

My team uses react-recurly and we want to upgrade to using amazon pay v2. However, react-recurly gets its type definitions from DefinitelyTyped. You can see here that that repo lacks any type definitions for amazon pay. While Recurly-JS has type definitions for amazon pay and builds automated PRs for that repo, it's been sending PRs that do not pass DefinitelyTyped CI tests. A couple recent examples: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68799 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68636

We cannot update to amazon pay v2 until the new types are merged to that repo.

devinsimmons commented 6 months ago

@chrissrogers it seems like at one point you may have been working on the DefinitelyTyped pull requests - I could always tidy up the most recent failed PR to address CI issues if someone from recurly reviews it

chrissrogers commented 6 months ago

@devinsimmons I'd be happy to review those changes.

devinsimmons commented 5 months ago

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/69067 made a PR in DT @chrissrogers

jakebailey commented 4 months ago

Where does the integration bot live that produces the DT package? It's been failing for months, and the hand-written PR wasn't correct as it forgot to bump the package version. Fixing it should be straightforward...

chrissrogers commented 4 months ago

@jakebailey The workflow is defined here

douglasmiller commented 2 months ago

This should be fixed by #884

jakebailey commented 2 months ago

I don't think it is a fix in full; that PR does not include a package.json update to set the version, as that is no longer part of index.d.ts.

jakebailey commented 2 months ago

I sent https://github.com/recurly/recurly-js/pull/886 which do the trick.