recurly / recurly-js

Simple subscription billing in the browser
https://js.recurly.com/
MIT License
646 stars 139 forks source link

Wrong type of AlternativePaymentMethods start and initiate #885

Open jochem-van-eldijk opened 2 months ago

jochem-van-eldijk commented 2 months ago

Passing the options object to the start method does noting:

https://github.com/recurly/recurly-js/blob/3868a4a91ff2fbce2869c2d7d0b4951c95067af8/types/lib/alternative-payment-methods.d.ts#L86

instead it should be passed when creating a AlternativePaymentMethodsInstance here:

https://github.com/recurly/recurly-js/blob/3868a4a91ff2fbce2869c2d7d0b4951c95067af8/types/lib/alternative-payment-methods.d.ts#L104

you can see this also being done in your example repo: recurly-integration-examples/public/alternative-payment-methods/ideal.html

on this line: https://github.com/recurly/recurly-integration-examples/blob/a1b6502b736f225b04c33e3249822830bad0e71a/public/alternative-payment-methods/ideal.html#L64