recursecenter / pairing-bot

A Zulip bot that partners people for pair programming practice
MIT License
22 stars 15 forks source link

Refactor with interfaces for DB and Zulip interaction #18

Closed parsn1psoup closed 3 years ago

parsn1psoup commented 3 years ago

Interfaces will allow us to mock the DB and Zulip interaction, and have more unit tests. This PR does the following:

To do:

This PR is pretty big and I'm not sure if it's reviewable or testable enough to be merged as is. Even if we don't end up merging it, it has been useful as a learning project and can maybe serve as a reference for future discussions.

Thanks @rickypai, @nyghtowl, @Mathew-Estafanous and @ameliariely for advice and pairing sessions on this!

stillgreenmoss commented 3 years ago

This is such a great contribution to pairing bot and i'm stoked to do whatever's necessary to get all these changes into production! @parsn1psoup and I are chatting out-of-band, and it sounds like we're gonna work on merging (and thus going to production) sometime this week.

Seconding @parsn1psoup -- huge thanks to all of you @rickypai @nyghtowl @Mathew-Estafanous @ameliariely 🙏

Mathew-Estafanous commented 3 years ago

Sounds great! @thwidge & @parsn1psoup If you guys are ok with it, could I join you guys as you work on getting this update on to production?

stillgreenmoss commented 3 years ago

@Mathew-Estafanous Yes absolutely! I'll start a group chat on zulip

parsn1psoup commented 3 years ago

Thank you for the comments @rickypai ! Should be resolved now.